OpenWrt/openwrt-luci
1
0
Fork 0
mirror of https://github.com/openwrt/luci synced 2025-01-09 04:28:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

luci-base: form.js: make map readonly on insufficient uci permissions

Browse Source 
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This commit is contained in:
Jo-Philipp Wich 2020-04-13 17:48:06 +02:00
parent c89fd0a7f3
commit 5c22340f43
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
modules/luci-base/htdocs/luci-static/resources/form.js
View File

@ -1,11 +1,19 @@
'use strict';
'require ui';
'require uci';
'require rpc';
'require dom';
'require baseclass';
var scope = this;
var callSessionAccess = rpc.declare({
object: 'session',
method: 'access',
params: [ 'scope', 'object', 'function' ],
expect: { 'access': false }
});
var CBIJSONConfig = baseclass.extend({
__init__: function(data) {
data = Object.assign({}, data);
@ -360,7 +368,6 @@ var CBIMap = CBIAbstractElement.extend(/** @lends LuCI.form.Map.prototype */ {
this.config = config;
this.parsechain = [ config ];
this.readonly = false;
this.data = uci;
},
@ -370,6 +377,10 @@ var CBIMap = CBIAbstractElement.extend(/** @lends LuCI.form.Map.prototype */ {
* If set to `true`, the Map instance is marked readonly and any form
* option elements added to it will inherit the readonly state.
*
* If left unset, the Map will test the access permission of the primary
* uci configuration upon loading and mark the form readonly if no write
* permissions are granted.
*
* @name LuCI.form.Map.prototype#readonly
* @type boolean
*/
@ -520,8 +531,17 @@ var CBIMap = CBIAbstractElement.extend(/** @lends LuCI.form.Map.prototype */ {
* an error.
*/
load: function() {
return this.data.load(this.parsechain || [ this.config ])
.then(this.loadChildren.bind(this));
var doCheckACL = (!(this instanceof CBIJSONMap) && this.readonly == null);
return Promise.all([
doCheckACL ? callSessionAccess('uci', this.config, 'write') : true,
this.data.load(this.parsechain || [ this.config ])
]).then(L.bind(function(res) {
if (res[0] === false)
this.readonly = true;
return this.loadChildren();
}, this));
},
/**