Windy/komga
1
0
Fork 0
mirror of https://github.com/gotson/komga.git synced 2025-01-09 04:08:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: close SSE connections during shutdown

Browse Source 
this will allow for graceful shutdown to finish without timeout

Closes: #1028
This commit is contained in:
Gauthier Roebroeck 2023-01-04 10:35:51 +08:00
parent 07681b26c6
commit 3f773d1ed7
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
komga/src/main/kotlin/org/gotson/komga/interfaces/sse/SseController.kt
View File

@ -24,6 +24,7 @@ import org.gotson.komga.interfaces.sse.dto.ThumbnailBookSseDto
import org.gotson.komga.interfaces.sse.dto.ThumbnailReadListSseDto
import org.gotson.komga.interfaces.sse.dto.ThumbnailSeriesCollectionSseDto
import org.gotson.komga.interfaces.sse.dto.ThumbnailSeriesSseDto
import org.springframework.context.SmartLifecycle
import org.springframework.http.MediaType
import org.springframework.jms.annotation.JmsListener
import org.springframework.jms.core.JmsTemplate
@ -44,14 +45,16 @@ private val logger = KotlinLogging.logger {}
class SseController(
private val bookRepository: BookRepository,
private val jmsTemplate: JmsTemplate,
) {
) : SmartLifecycle {
private var acceptingConnections = true
private val emitters = Collections.synchronizedMap(HashMap<SseEmitter, KomgaUser>())
@GetMapping("sse/v1/events")
fun sse(
@AuthenticationPrincipal principal: KomgaPrincipal,
): SseEmitter {
if (!acceptingConnections) throw IllegalStateException("Server is shutting down, not accepting new SSE connections")
val emitter = SseEmitter()
emitter.onCompletion { synchronized(emitters) { emitters.remove(emitter) } }
emitter.onTimeout { emitter.complete() }
@ -135,4 +138,18 @@ class SseController(
}
}
}
override fun start() = Unit
override fun stop() {
logger.debug { "Closing all SSE connections" }
acceptingConnections = false
synchronized(emitters) {
emitters.forEach { (emitter, _) -> emitter.completeWithError(Exception("Server stopping")) }
}
}
override fun isRunning(): Boolean = true
override fun getPhase(): Int = SmartLifecycle.DEFAULT_PHASE
}