diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 63707068..4f1a06b4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -82,7 +82,7 @@ jobs: - uses: actions/setup-node@v4 with: - node-version: '16' + node-version-file: '.nvmrc' cache: 'npm' cache-dependency-path: komga-webui/package-lock.json diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 656855d2..1e71704e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -59,7 +59,7 @@ jobs: run: diff --unified ./komga-tray/conveyor/required-jdk-modules.txt ./output/required-jdk-modules.txt - name: Upload JDK required modules - if: failure() + if: steps.conveyor_compare.outcome == 'failure' uses: actions/upload-artifact@v3 with: name: conveyor-required-jdk-modules @@ -72,7 +72,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: '16' + node-version-file: '.nvmrc' cache: 'npm' cache-dependency-path: komga-webui/package-lock.json - name: npm install diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 00000000..3c032078 --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +18 diff --git a/DEVELOPING.md b/DEVELOPING.md index 6eb252a3..7eaacaf3 100644 --- a/DEVELOPING.md +++ b/DEVELOPING.md @@ -7,7 +7,7 @@ Thanks a lot for contributing to Komga! You will need: - Java JDK version 17 & 21 -- Nodejs version 16+ +- Nodejs version 18+ (check the `.nvmrc` file) ## Setting up the project