From 89518fe3f6aec1057232b3e7af0f7489e02eb3dd Mon Sep 17 00:00:00 2001 From: Poker Date: Fri, 6 Dec 2024 01:31:08 +0800 Subject: [PATCH] =?UTF-8?q?=E6=9B=B4=E6=96=B0IssueTemplate=20(#550)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/ISSUE_TEMPLATE/bug_report.yaml | 70 ++++++++++--------- .github/ISSUE_TEMPLATE/bug_report_zh.yaml | 60 ---------------- .github/ISSUE_TEMPLATE/feature_request.yaml | 47 +++++++++---- .../ISSUE_TEMPLATE/feature_request_zh.yaml | 34 --------- .../AdvancedItemsView.xaml.cs | 4 +- 5 files changed, 71 insertions(+), 144 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug_report_zh.yaml delete mode 100644 .github/ISSUE_TEMPLATE/feature_request_zh.yaml diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index d0553d08..4ff7b3e7 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -1,60 +1,62 @@ -name: Bug report -description: Report a bug -title: A brief description of the bug +name: 漏洞反馈 / Bug Report +description: 报告一个漏洞 / Report a bug labels: [bug 🐛] body: + - type: markdown + attributes: + value: | + ## 在开始之前 / Before you begin + + 🚨 **请勿略过说明 / Please do not skip instructions** 🚨 + + 1. 请确保在打开一个新议题之前，查找并确认不要与已有议题重复。 + 2. WPF版本已不再维护，除非重大BUG其他情况下都会直接关闭议题。 + 3. 请尽可能多地提供信息，如果软件崩溃请一并提供崩溃日志。 + + 1. Please make sure to look for existing issues about the same problem before opening a new one. + 2. The WPF version is no longer maintained and issues are simply closed unless there is a major bug. + 3. Please provide as much information as possible, and if the software crashes, please provide crash logs as well. - type: dropdown validations: required: true attributes: - label: Pixeval's version + label: Pixeval的版本 / Pixeval's version options: - - WinUI3 + - WinUI 3 - WPF - type: textarea validations: required: true attributes: - label: Description of the problem - description: Please describe the bug concisely and completely. You can attach the code that went wrong if you know + label: 问题描述 / Description of the problem + description: | + 请简练、完整地描述这个漏洞，如果了解也可以附上出错部分代码 + Please describe the bug concisely and completely. You can attach the code that went wrong if you know - type: textarea attributes: - label: Screenshot - description: If possible, attach a screenshot when the error occurred + label: 屏幕截图 / Screenshot + description: | + 如果可以，请附上发生错误时的屏幕截图 + If possible, attach a screenshot when the error occurred - type: textarea attributes: - label: Error code - description: If possible, attach the full error code and exception stack trace + label: 错误代码 / Error code + description: | + 如果可以，请附上软件显示的完整错误代码和异常堆栈信息 + If possible, attach the full error code and exception stack trace - type: dropdown validations: required: true attributes: - label: Windows major version - description: Major version of Windows + label: Windows主要版本 / Windows major version multiple: true options: - Windows 11 - Windows 10 - - Earlier than Windows 10 (not supported in WinUI3) - - type: dropdown - attributes: - label: Specific Windows version - description: If you know about this, please provide a more specific version - multiple: true - options: - - Insider Build - - Windows 11 22H2 (22621) - - Windows 11 21H2 (22000) - - November 2021 Update/21H2 (19044) - - May 2021 Update/21H1 (19043) - - October 2020 Update/20H2 (19042) - - October 2018 Update/RS5 (17763) - - Windows 8.1 - - Windows 8 - - Windows 7 - - Windows Vista - - Windows XP and earlier + - 比 Windows 10 更早的版本（WinUI3 版不支持此项） / Earlier than Windows 10 (not supported in WinUI3) - type: textarea attributes: - label: Additional Information - description: Any additional information you would like to provide + label: 其他信息 / Additional Information + description: | + 任何你想提供的其他信息 + Any additional information you would like to provide diff --git a/.github/ISSUE_TEMPLATE/bug_report_zh.yaml b/.github/ISSUE_TEMPLATE/bug_report_zh.yaml deleted file mode 100644 index 52d375dc..00000000 --- a/.github/ISSUE_TEMPLATE/bug_report_zh.yaml +++ /dev/null @@ -1,60 +0,0 @@ -name: 漏洞反馈 -description: 报告一个漏洞 -title: 漏洞的简要叙述 -labels: [bug 🐛] -body: - - type: dropdown - validations: - required: true - attributes: - label: Pixeval的版本 - options: - - WinUI3 - - WPF - - type: textarea - validations: - required: true - attributes: - label: 问题描述 - description: 请简练、完整地描述这个漏洞，如果了解也可以附上出错部分代码 - - type: textarea - attributes: - label: 屏幕截图 - description: 如果可以，请附上发生错误时的屏幕截图 - - type: textarea - attributes: - label: 错误代码 - description: 如果可以，请附上软件显示的完整错误代码和异常堆栈信息 - - type: dropdown - validations: - required: true - attributes: - label: Windows主要版本 - description: Windows的大版本 - multiple: true - options: - - Windows 11 - - Windows 10 - - 比 Windows 10 更早的版本（WinUI3 版不支持此项） - - type: dropdown - attributes: - label: 具体Windows版本 - description: 如果你对此项了解，请提供更具体的版本 - multiple: true - options: - - Insider Build - - Windows 11 22H2 (22621) - - Windows 11 21H2 (22000) - - November 2021 Update/21H2 (19044) - - May 2021 Update/21H1 (19043) - - October 2020 Update/20H2 (19042) - - October 2018 Update/RS5 (17763) - - Windows 8.1 - - Windows 8 - - Windows 7 - - Windows Vista - - Windows XP及更早 - - type: textarea - attributes: - label: 其他信息 - description: 任何你想说的其他信息 diff --git a/.github/ISSUE_TEMPLATE/feature_request.yaml b/.github/ISSUE_TEMPLATE/feature_request.yaml index 00becaf4..698933a4 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yaml +++ b/.github/ISSUE_TEMPLATE/feature_request.yaml @@ -1,34 +1,53 @@ -name: feature request -description: Propose new features or optimizations that you want Pixeval to implement -title: A brief description of the feature +name: 功能建议 / Feature Request +description: 提出你希望软件实现的新功能或优化 / Propose new features or optimizations that you want Pixeval to implement labels: [feature ✨] body: + - type: markdown + attributes: + value: | + ## 在开始之前 / Before you begin + + 🚨 **请勿略过说明 / Please do not skip instructions** 🚨 + + 1. 请确保在打开一个新议题之前，查找并确认不要与已有议题重复。 + 2. WPF版本已不再维护，除非重大BUG其他情况下都会直接关闭议题。 + 3. 只支持Win10，而Win11不支持的功能建议，大概率不会被接受。 + + 1. Please make sure to look for existing issues about the same problem before opening a new one. + 2. The WPF version is no longer maintained and issues are simply closed unless there is a major bug. + 3. Feature requests that only support Win10 and not Win11 will most likely not be accepted. - type: dropdown validations: required: true attributes: - label: The type of your suggestion + label: 建议类型 options: - - New feature - - Feature optimization + - 新功能 + - 功能优化 - type: dropdown validations: required: true attributes: - label: Pixeval's version + label: Pixeval的版本 options: - - WinUI3 + - WinUI 3 - type: textarea validations: required: true attributes: - label: Description - description: Please describe your suggestion concisely and completely + label: 描述 / Description + description: | + 请简练、完整地描述你的建议 + Please describe your suggestion concisely and completely - type: textarea attributes: - label: Pictures - description: If possible, please illustrate your suggestion + label: 图片 / Pictures + description: | + 如果可以，请图文并茂地叙述你的建议 + If possible, please illustrate your suggestion - type: textarea attributes: - label: Additional Information - description: Any additional information you would like to provide + label: 其他信息 / Additional Information + description: | + 任何你想提供的其他信息 + Any additional information you would like to provide diff --git a/.github/ISSUE_TEMPLATE/feature_request_zh.yaml b/.github/ISSUE_TEMPLATE/feature_request_zh.yaml deleted file mode 100644 index b6ea4a87..00000000 --- a/.github/ISSUE_TEMPLATE/feature_request_zh.yaml +++ /dev/null @@ -1,34 +0,0 @@ -name: 功能建议 -description: 提出你希望软件实现的新功能或优化 -title: 功能的简要叙述 -labels: [feature ✨] -body: - - type: dropdown - validations: - required: true - attributes: - label: 建议类型 - options: - - 新功能 - - 功能优化 - - type: dropdown - validations: - required: true - attributes: - label: Pixeval的版本 - options: - - WinUI3 - - type: textarea - validations: - required: true - attributes: - label: 描述 - description: 请简练、完整地描述你的建议 - - type: textarea - attributes: - label: 图片 - description: 如果可以，请图文并茂地叙述你的建议 - - type: textarea - attributes: - label: 其他信息 - description: 任何你想说的其他信息 diff --git a/src/Pixeval.Controls/AdvancedItemsView/AdvancedItemsView.xaml.cs b/src/Pixeval.Controls/AdvancedItemsView/AdvancedItemsView.xaml.cs index 29378a74..cc73812e 100644 --- a/src/Pixeval.Controls/AdvancedItemsView/AdvancedItemsView.xaml.cs +++ b/src/Pixeval.Controls/AdvancedItemsView/AdvancedItemsView.xaml.cs @@ -88,9 +88,9 @@ public sealed partial class AdvancedItemsView : ItemsView SelectionChanged += AdvancedItemsViewOnSelectionChanged; LoadMoreRequested += async (sender, args) => { - if (sender.To() is { ItemsSource: ISupportIncrementalLoading sil } aiv) + if (sender is { ItemsSource: ISupportIncrementalLoading sil }) { - _ = await sil.LoadMoreItemsAsync((uint)aiv.LoadCount); + _ = await sil.LoadMoreItemsAsync((uint)sender.LoadCount); return sil.HasMoreItems; }